Feature/skill self debug and systemd service#879
Conversation
|
Note this is supplied as a self-contained skill, so that other options can be included easily. |
Advanced use-casesAlthough picoclaw has built in support for multiple agents, this scheme provides the flexibility for
Personal note: |
nikolasdehor
left a comment
nikolasdehor
left a comment
There was a problem hiding this comment.
Interesting and useful skill concept — self-debugging is a powerful capability. Several issues: (1) Shell injection risk: SKILL.md tools pass PICOCLAW_SERVICE_NAME directly into exec commands. If the service name contains shell metacharacters, this could be exploited. Consider validating/sanitizing the service name. (2) macOS script parity: The launchd script lacks error handling compared to systemd — uses 'which' instead of 'command -v', no check for picoclaw binary existence, missing trailing newline. (3) Log location on macOS: /tmp/service_name.log is world-readable and cleared on reboot. Consider ~/Library/Logs/. (4) SKILL.md quoting: exec picoclaw --config PICOCLAW_CONFIG status has nested double quotes that would break in shell. (5) Scope question: Is workspace/skills/ the correct location for bundled skills?
|
I am tidying this PR, watch this space. |
|
Are you now explicitly blocking systemctl and journalctl ? The whole reason I am using picoclaw is to manage my infrastructure. |
keithy
force-pushed
the
feature/skill_self-debug_and_systemd_service
branch
from
ee58508 to
aa441ea
Compare
|
This PR has been reworked, all actions are implemented through a script with full parameter sanitization. depends on: #896 |
keithy
force-pushed
the
feature/skill_self-debug_and_systemd_service
branch
5 times, most recently
from
edb440d to
fc3c189
Compare
Introduces the `self-debug` skill, a new capability designed to help users and the agent itself diagnose its own state. This provides a standardized way to inspect logs, service status, and configuration without requiring platform-specific knowledge. This new skill includes: - A cross-platform `debug.sh` helper script for Linux (systemd) and macOS (launchd). - Key diagnostic actions: `logs`, `logs-errors`, `service-status`, and `config-safe`. - Service installation scripts for both systemd and launchd to streamline setup. - Comprehensive `SKILL.md` documentation with a clear action table and usage examples. This feature simplifies troubleshooting and provides essential, built-in tools for maintaining agent health.
keithy
force-pushed
the
feature/skill_self-debug_and_systemd_service
branch
from
fc3c189 to
a11816e
Compare
2 participants
📝 Description
This PR introduces essential stability and observability features for PicoClaw.
It adds a Self-Debug Skill to allow the agent to diagnose its own execution failures from logs
and a Systemd Service installer to ensure the agent runs as a persistent, background daemon.
🗣️ Type of Change
[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 📖 Documentation update
[x] ⚡ Code refactoring (improved service management)
🤖 AI Code Generation
[x] 👨💻 Mostly Human-written (Human lead)
🔗 Related Issue
📚 Technical Context
Reference URL: https://github.com/keithy/picoclaw/tree/feature/skill_self-debug_and_systemd_service
🧪 Test Environment
Hardware: Rock64 (ARM64)
OS: Debian/Ubuntu (Linux) armbian, mise
Channels: CLI / Local Daemon
☑️ Checklist
[x] My code/docs follow the style of this project.
[x] I have performed a self-review of my own changes.
[x] I have updated the documentation (added systemd instructions).